Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for IPLS (v2.3) and TIPL/TMCL (v2.4) frames #141

Merged
merged 9 commits into from
Nov 22, 2024
Merged

feat: Add support for IPLS (v2.3) and TIPL/TMCL (v2.4) frames #141

merged 9 commits into from
Nov 22, 2024
+438 −11

Conversation

Holzhaus
Copy link
Contributor

@Holzhaus Holzhaus marked this pull request as draft November 11, 2024 21:23
@Holzhaus Holzhaus changed the title feat: Add support for IPLS frame feat: Add support for IPLS (v2.3) and TIPL/TMCL (v2.4) frames Nov 12, 2024
@Holzhaus Holzhaus marked this pull request as ready for review November 13, 2024 20:20
polyfloyd
polyfloyd requested changes Nov 15, 2024
View reviewed changes
Copy link
Owner

@polyfloyd polyfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some comments.

Furthermore, do you have a file that contains such a tag that you could perhaps include as part of the test suite? You do not have to include the whole audio file, just separating the tag with a tool like dd is sufficient.

src/frame/content.rs Outdated Show resolved Hide resolved
src/frame/content.rs Outdated Show resolved Hide resolved
src/stream/frame/content.rs Show resolved Hide resolved
@Holzhaus
Copy link
Contributor Author

Thanks! I left some comments.

Furthermore, do you have a file that contains such a tag that you could perhaps include as part of the test suite? You do not have to include the whole audio file, just separating the tag with a tool like dd is sufficient.

Tests added in f438a3d

@polyfloyd polyfloyd merged commit cc120c7 into polyfloyd:main Nov 22, 2024
16 checks passed
@polyfloyd
Copy link
Owner

Thanks!

@Holzhaus Holzhaus deleted the ipls-support branch November 22, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polyfloyd polyfloyd Awaiting requested review from polyfloyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Holzhaus @polyfloyd