fix(crash): idle users array out-of-bounds

polonel · Dec 6, 2018 · ebacda9 · ebacda9
1 parent 527b234
commit ebacda9
Showing 1 changed file with 16 additions and 5 deletions.
diff --git a/src/socketserver.js b/src/socketserver.js
@@ -628,11 +628,22 @@ var socketServer = function(ws) {
                     utils.sendToSelf(socket, '$trudesk:chat:updateOnlineBubbles', {sortedUserList: sortedUserList, sortedIdleList: sortedIdleList});
                 }
             } else {
-                idleUsers[user.username].sockets.push(socket.id);
-                sortedUserList = _.fromPairs(_.sortBy(_.toPairs(usersOnline), function(o) { return o[0]; }));
-                sortedIdleList = _.fromPairs(_.sortBy(_.toPairs(idleUsers), function(o) { return o[0]; }));
-
-                utils.sendToSelf(socket, '$trudesk:chat:updateOnlineBubbles', {sortedUserList: sortedUserList, sortedIdleList: sortedIdleList});
+                var idleUser = idleUsers[user.username.toLowerCase()];
+                if (!_.isUndefined(idleUser)) {
+                    idleUser.sockets.push(socket.id);
+
+                    sortedUserList = _.fromPairs(_.sortBy(_.toPairs(usersOnline), function (o) {
+                        return o[0];
+                    }));
+                    sortedIdleList = _.fromPairs(_.sortBy(_.toPairs(idleUsers), function (o) {
+                        return o[0];
+                    }));
+
+                    utils.sendToSelf(socket, '$trudesk:chat:updateOnlineBubbles', {
+                        sortedUserList: sortedUserList,
+                        sortedIdleList: sortedIdleList
+                    });
+                }
             }
         });