Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 2 & 3 compat #611

Closed
jacogr opened this issue Feb 10, 2022 · 7 comments · Fixed by #732
Closed

Vue 2 & 3 compat #611

jacogr opened this issue Feb 10, 2022 · 7 comments · Fixed by #732

Comments

@jacogr
Copy link
Member

jacogr commented Feb 10, 2022

Not sure how that story plays out - when just bumping the deps to 3.x we have issues. If not compatible, need some way to support both.

@tinydjp
Copy link

tinydjp commented Mar 20, 2022

Hi @jacogr may I know is there any plan for the upgrade?

@jacogr
Copy link
Member Author

jacogr commented Mar 20, 2022

It needs to be done, which is why it is logged. :)

PRs for a Vue 3.x version that replaces Vue.extend with createComponent always welcome.

When releasing it it will mean that we will bump to version 2.0 here and probably provide the old/current version as @polkadot/vue2-identicon (so users can use either version, but the default being the one on the latest Vue 3 framework)

@dcolley
Copy link
Contributor

dcolley commented May 23, 2022

In my experience vue2 and vue3 are different enough to require different repos / branches

@jacogr
Copy link
Member Author

jacogr commented May 23, 2022

It is a bit out of my wheelhouse... but if possible, would prefer to have package/vue2-identicon and packages/vue-identicon for vue3. They do operate independently inside packages/*.

If not at all possible.... well, then I guess The 2.x series would be for vue 2 and vue 3 will need a major bump. (It would need a major bump when renaming anyway, so with either option that is a given)

@vikiival
Copy link
Contributor

It is possible to use Vue-demi

@dcolley
Copy link
Contributor

dcolley commented Jul 20, 2022

I would not recommend tracking different versions of vue in your code - that's what branches are for.

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants