Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Details broken for blocks/chains with V1 Weight #11040

Open
MPM1107 opened this issue Oct 27, 2024 · 0 comments
Open

Block Details broken for blocks/chains with V1 Weight #11040

MPM1107 opened this issue Oct 27, 2024 · 0 comments
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow.

Comments

@MPM1107
Copy link

MPM1107 commented Oct 27, 2024

The Block Details tab in the explorer throws an error for chains still using V1Weight, and all chains if looking up an old block that still used V1. The error thrown is v2Weight.proofSize.toBn is not a function. I suspect this was caused by #10639, when a V1 Weight object is automatically converted to V2, the proofSize of the result gets set to BN_ZERO, which seems to not have a toBn method I assume? Not sure what the correct way to go about fixing this would be, so opening this issue instead of submitting a PR.

@TarikGul TarikGul added Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow. labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow.
Projects
Development

No branches or pull requests

2 participants