-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata format for messages/constructors in a .contract
bundle changed
#4255
Comments
We need a version bump somewhere so I can actually detect what I'm working with. It is impossible otherwise. I basically pass the parser a schema to follow, it is not manually generated. So can support either/or on a single version. If we do bump eg V1 to V2, it can be done with no issues. (Case in-point, the rc.6 with the broken metadata that was pulled still gives me support issues which I'd rather not deal with - it detracts from getting stuff out the door) |
Thanks for the quick reply! And the issue transfer :-). We've bumped the metadata version to |
Brilliant. Will try to get support into the next API release (Monday), depending on other chaos. |
Do you maybe have an example with events? I am assuming it also has the label change, but would like to verify and add it to the tests as well. |
Good point, I uploaded the |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query. |
The metadata supplied for a contract in the
.contract
bundle will change a bit.Specifically the messages and constructors exposed by a contract were previously denoted with
Now they are instead denoted with
I've attached two files:
flipper
example.If you
diff flipper.contract.new flipper.contract.old
the changes are visible.The PR on ink! side which does this is use-ink/ink#923, we will hold-off merging it until the UI supports these changes. I'll also create follow-up issues for ask! and Solang after the new format is supported.
The text was updated successfully, but these errors were encountered: