Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the maximum length of identity raw data values from 32 bytes #76

Closed
wants to merge 3 commits into from

Conversation

ltfschoen
Copy link

No description provided.

@bkchr
Copy link
Contributor

bkchr commented Feb 20, 2024

The identity is now generic and configured in the runtime. Generally not sure we need a RFC for such a change. I think it is fine to just do this as a pr and convincing of the maintainers.

CC @joepetrowski

@ggwpez
Copy link
Member

ggwpez commented Feb 20, 2024

I think Joe is OOO, but currently we re-use this Data type in the new Rococo people config and partly in Polkadot.
It should be enough to make that 32 there generic as Get<u32>.

Then in a second change you can increase it for the Polkadot runtime config.

@joepetrowski
Copy link
Contributor

Yeah I agree with @ggwpez and @bkchr , should be a PR to polkadot-sdk to make that value configurable and then we can propose the change in the pallet config.

@bkchr
Copy link
Contributor

bkchr commented Apr 3, 2024

@ltfschoen are you okay with the proposed steps?

@ltfschoen
Copy link
Author

@ltfschoen are you okay with the proposed steps?

yes i agree with @ggwpez, @joepetrowski, and yourself

@bkchr
Copy link
Contributor

bkchr commented Apr 3, 2024

So this can be closed?

@ltfschoen
Copy link
Author

Closed and replaced with Polkadot SDK issue paritytech/polkadot-sdk#3977

@ltfschoen ltfschoen closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants