Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(refactor): don't persist system external accounts, remove proxy delegates state #1639

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

rossbulat
Copy link
Collaborator

@rossbulat rossbulat commented Nov 14, 2023

  • No longer stores proxy delegates in a separaste state object, and instead introduces a formatProxiesToDelegates to discover them on the fly. This prevents re-renders.
  • system external accounts are no longer persisted in local storage.

About system external account changes

To prevent edge cases in read only account management, system accounts are no longer persisted in local storage.

System accounts are discovered after the initial account import process, and may replace existing user based read only accounts. This is a dynamic process, and the user added accounts still need to be persisted in local storage. This update will allow these accounts to be remembered even if they are updated to system accounts.

Includes a migration to remove existing system external accounts from local storage.

@rossbulat rossbulat changed the title feat(refactor): don't persist system external accounts feat(refactor): don't persist system external accounts, remove proxy delegates state Nov 14, 2023
@rossbulat rossbulat merged commit 56314ae into main Nov 14, 2023
9 checks passed
@rossbulat rossbulat deleted the rb-proxies-revisio branch November 14, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant