Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Module for Raspberry Pi Pico + Implementation security #44

Open
gpsa opened this issue May 18, 2024 · 3 comments
Open

Display Module for Raspberry Pi Pico + Implementation security #44

gpsa opened this issue May 18, 2024 · 3 comments

Comments

@gpsa
Copy link

gpsa commented May 18, 2024

Do you think that adding a "Display Module for Raspberry Pi Pico" would solve the problem of having to keep the encryption key plain text?

If so, would you be able to point out which part of the code would require a change to wait on user's input?

@polhenarejos
Copy link
Owner

All Pico Keys firmware are designed to work without any 3rd hardware dependencies. Of course you could add a secure element or display module, but it would run entirely on your side.

@gpsa
Copy link
Author

gpsa commented May 30, 2024

Gotcha! Would you mind pointing where in the code we might need changes to do this?

@polhenarejos
Copy link
Owner

Function board_button_read() at https://github.com/polhenarejos/pico-keys-sdk/blob/e4e43dae04d093286bd532d7486b24e8237b4960/src/main.c#L206 is the one that returns true or false when BOOTSEL button is pressed or release. You could override it by taking the prompt from display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants