fix(rust, python): properly handle json with unclosed strings #5427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5371
A little note about the implementation. The
SplitLines
iterator is not really designed to handle all the nuances of json parsing. So I decided to go back to leveraging theserde_json:: StreamDeserializer
, but now we are using it exclusively as a mechanism to iterate over the rows. We can do this via theRawValue
type inserde_json
. Which just returns the rawstr
of each row without doing any parsing of the values, acting as a drop in replacement toSplitLines
.The actual parsing of the rows is still done by
simd_json
. So the performance impact should be minimal. I'll post some benchmarks once my release build is finished.