build(python): Update pyo3 and numpy crates to version 0.23

[bschoenmaeckers]

Updated to latest pyo3 while ignoring most deprecations for now.

[codecov]

Codecov Report

Attention: Patch coverage is 57.12954% with 460 lines in your changes missing coverage. Please review.

Project coverage is 79.61%. Comparing base (f599e88) to head (73f3a90).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
.../polars-python/src/lazyframe/visitor/expr_nodes.rs	0.00%	293 Missing ⚠️
...rates/polars-python/src/lazyframe/visitor/nodes.rs	8.53%	75 Missing ⚠️
crates/polars-python/src/map/series.rs	66.21%	25 Missing ⚠️
crates/polars-python/src/series/aggregation.rs	74.07%	14 Missing ⚠️
crates/polars-python/src/lazyframe/visit.rs	23.52%	13 Missing ⚠️
crates/polars-python/src/conversion/mod.rs	90.32%	9 Missing ⚠️
crates/polars-python/src/series/general.rs	66.66%	5 Missing ⚠️
crates/polars-python/src/cloud.rs	33.33%	4 Missing ⚠️
crates/polars-python/src/map/lazy.rs	69.23%	4 Missing ⚠️
crates/polars-python/src/map/dataframe.rs	75.00%	3 Missing ⚠️
... and 7 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #20111      +/-   ##
==========================================
+ Coverage   79.59%   79.61%   +0.02%     
==========================================
  Files        1565     1565              
  Lines      218462   218316     -146     
  Branches     2475     2475              
==========================================
- Hits       173885   173816      -69     
+ Misses      44010    43933      -77     
  Partials      567      567              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stinodego]

@bschoenmaeckers Thanks for picking this up! Looks like the new PyO3 version causes deadlock somewhere - can you reproduce this locally? There's probably a clue in the migration guide somewhere on what could be causing this.

[bschoenmaeckers]

@bschoenmaeckers Thanks for picking this up! Looks like the new PyO3 version causes deadlock somewhere - can you reproduce this locally? There's probably a clue in the migration guide somewhere on what could be causing this.

Haven't had time to dig deeper today, but I could quite consistently reproduce this error locally with the following command.

pytest tests/unit/operations/map/test_map_elements.py -n 4 --verbose

[bschoenmaeckers]

Deadlock happens in the Display implementation of PyErr when 2 threads call warning_function at the same time. Will investigate further to reproduce this within Pyo3.

polars/crates/polars-python/src/on_startup.rs

Lines 58 to 66 in bcfa7ec

	fn warning_function(msg: &str, warning: PolarsWarning) {
	Python::with_gil(|py| {
	let warn_fn = UTILS.bind(py).getattr(intern!(py, "_polars_warn")).unwrap();
	if let Err(e) = warn_fn.call1((msg, Wrap(warning))) {
	eprintln!("{e}")
	}
	});
	}

[ritchie46]

@bschoenmaeckers

Ah (spent too many hours on this0, I also came to the conclusion that it is related to the warning. What I observe is that the GIL doesn't matter, but if I call warning.warn in _polars_warn we deadlock. if we do anything else there it seems to be ok.

[bschoenmaeckers]

Does this solve the deadlock? https://github.com/PyO3/pyo3/pull/4766/files

Looks like it does!

[ritchie46]

Great! :)

[bschoenmaeckers]

I fixed all the deprecation warnings. So this is ready for review.

[bschoenmaeckers]

I can add back the temporary fix for PyO3/pyo3#4764 until PyO3/pyo3#4766 is released. If that is desirable.

[ritchie46]

Thanks a lot @bschoenmaeckers. Can you rebase? There are some conflicts.

[bschoenmaeckers]

Thanks a lot @bschoenmaeckers. Can you rebase? There are some conflicts.

Done,

[ritchie46]

Thanks a lot for pushing this effort @bschoenmaeckers. Greatly appreciated. P.S. I see you live in the Netherlands. Might you be interested, we're hiring ;)