Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish switching to PyO3 0.21's native datetime support, now available with abi3, once Python 3.9 is the minimum version #16199

Open
itamarst opened this issue May 13, 2024 · 5 comments
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature

Comments

@itamarst
Copy link
Contributor

Description

In Python 3.9 there's now a timezone database available. That means PyO3 can have native timezone conversion between chrono_tz::Tz and Python timezone objects.

Currently Polars has its own custom conversion code, which is likely slower than PyO3's since it's in Python. However, until Python 3.9 is the minimum supported version, this change can't happen. I.e. this should be revisited in November 2024 or later.

(See also #16158, where most of the relevant work was done.)

@itamarst
Copy link
Contributor Author

I will try to do this.

@itamarst
Copy link
Contributor Author

itamarst commented Oct 11, 2024

Another place that should be updated maybe is conversion/any_value.rs in polars-python crate, which refers to some limitation in abi3-py37.

@mcrumiller
Copy link
Contributor

Is this related to #20111?

@itamarst
Copy link
Contributor Author

itamarst commented Dec 8, 2024

It's not a requirement at least, it's been possible to implement this since Polars dropped 3.8 support (a month or two ago?).

@bschoenmaeckers
Copy link
Contributor

I'm interested to pick this up if nobody minds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature
Projects
Status: Ready
Development

No branches or pull requests

4 participants