Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort method is marked as deprecated #303

Closed
controversial opened this issue Dec 9, 2024 · 0 comments · Fixed by #304
Closed

sort method is marked as deprecated #303

controversial opened this issue Dec 9, 2024 · 0 comments · Fixed by #304
Labels
bug Something isn't working

Comments

@controversial
Copy link
Contributor

polars version: 0.17.0
platform: macOS
node: 22

Describe your bug.

The df.sort() method is erroneously marked as deprecated:
Screenshot 2024-12-09 at 5 04 41 PM

What are the steps to reproduce the behavior?

const df = pl.DataFrame({ a: [1, 2, 3]} );
df.sort('a');

What is the actual behavior?

Type system shows that .sort is deprecated

What is the expected behavior?

The intention appears to have been to deprecate the parameter named reverse, but in fact the entire method is deprecated due to mistyped JSDoc syntax.

@controversial controversial added the bug Something isn't working label Dec 9, 2024
@controversial controversial changed the title Entire sort method is marked as deprecated Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant