Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Make 2-color checkbox #524

Open
ATEMVEGETA opened this issue Dec 29, 2023 · 3 comments
Open

Feature Request: Make 2-color checkbox #524

ATEMVEGETA opened this issue Dec 29, 2023 · 3 comments

Comments

@ATEMVEGETA
Copy link

ATEMVEGETA commented Dec 29, 2023

It would be nice if we had at least 1 more font color than yellow for checking a Pokemon. For example, we could have a different color for the Pokemon that you want to exclude from your Pokemon list and you don't want them to count in the total amount.

I personally have a living shiny Pokedex list and I mark the "caught" shiny Pokemon with the default yellow font box mark. But there are some Pokemon (like Meloetta and Victini) which are currently unable to be shiny. Those Pokemon though count for the total amount of shiny Pokemon to be caught. I wish I had some other colored mark box (preferably black) that I could add to those Pokemon and exclude them from the list, so they won't count either in the "total caught" or "yet to be caught" number.

@willdelorm
Copy link

I'd love to take a stab at this if the admins allow it. :)

Based on some initial investigating, it doesn't look like shiny data is being provided by the API. If there was a property tracking whether each Pokemon can be shiny, non-shiny Pokemon could be marked and filtered from the Progress bar.

@SlyAceZeta
Copy link

I actually want to discourage this one, because

  • A second "checkbox" color is useless for colorblind people (who might have an issue with the current site already)
  • The need to reflect shiny locks is already mentioned in disable shiny locked pokemon #277

@ATEMVEGETA
Copy link
Author

ATEMVEGETA commented Mar 24, 2024

I actually want to discourage this one, because

* A second "checkbox" color is useless for colorblind people (who might have an issue with the current site already)

* The need to reflect shiny locks is already mentioned in [disable shiny locked pokemon #277](https://github.com/pokedextracker/pokedextracker.com/issues/277)

I can't see the first one being a problem just by adding a second color. Colorblind people should have a problem also with the current single color (yellow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants