-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightbox for video element #741
Comments
@maorb I understand how it should work with image overlay, but how it will work in normal use, do you have an example of that? |
@arielk The way I did it once was to also use image overlay. So, if one wants to open the video inside a lightbox, I auto grabbed the video's featured image from youtube You may see example for this here: http://www.acri.org.il/education/our-vision Take a look also in the use of the iframe itself in the lightbox - the iframe src is being loaded only when user aasks to watch the video, which is better, since bo loading for iframe before that or on page load that may slow the page. (that is more important if you have a page with several yt iframes that should be loaed). I assume Vimeo can be approached in a same way. |
OK I guess it's possible, but I would prefer to keep it simple on the image overlay mode In any case we will consider including it in future updates, thanks for your feedback! |
Thank you very much :) |
@arielk you can consider something same as the image gallery. Same functionality . Video Gallery. |
We're considering adding this feature to additional widgets, such as a image, heading, button, etc |
p.s. @arielk Is there a way today to use the image carousel element with a lightbox efferct? |
I would also like too see a feature like this implemented in Elementor or Elementor Pro. |
Added for the next version: #1376 |
v1.3.0 released! |
Briliant. Thank you for the best plugin ever. Elementor for the win. Really appreicate the work you guys are doing.
[😃]
…________________________________
Från: Ariel Klikstein <[email protected]>
Skickat: den 6 mars 2017 19:10
Till: pojome/elementor
Kopia: copen8; Comment
Ämne: Re: [pojome/elementor] Lightbox for video element (#741)
Closed #741<#741>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#741 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AVhJPCy-cdur4GAWO4eNSE8-2T86DX9xks5rjEwLgaJpZM4KZw8e>.
|
Can that lightbox script be used (or targeted) in other areas of the site? |
Anyone have tips on debugging the issue if the lightbox is not coming up? I'm using OceanWP on this one site so I'm not sure if there's any conflict. When I use it for my other sites, the lightbox work. I check the console and there's no errors and I know the video is playing because there's the video's sound playing. |
Hi,
A great enhancement to the video element will be an option to allow playing the youtube/vimeo inside a lightbox/modal window in the middle of the screen. It will be very useful combined with image overlay, but also for the normal use.
The text was updated successfully, but these errors were encountered: