Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elementor 2.1.1 + XML Demo Import Bug #4947

Closed
5 tasks done
DeoThemes opened this issue Jul 4, 2018 · 14 comments
Closed
5 tasks done

Elementor 2.1.1 + XML Demo Import Bug #4947

DeoThemes opened this issue Jul 4, 2018 · 14 comments
Labels
bug Indicates a bug with one or multiple components. status/merged Indicates when a Pull Request has been merged to a Release.

Comments

@DeoThemes
Copy link

DeoThemes commented Jul 4, 2018

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • The issue still exists against the latest stable version of Elementor.

Description

After recent update from version 2.0.16 to 2.1.1 the XML demo content import is broken. It was working well with 2.0.16

Steps to reproduce

  1. Tools > Export
  2. Import to another domain address using One Click Demo Import plugin.
  3. Layout is broken

Isolating the problem

  • This bug happens with only Elementor plugin active (and Elementor Pro).
  • This bug happens with a default WordPress theme active.
  • I can reproduce this bug consistently using the steps above.

Environment

System Info ```

== Server Environment ==
Operating System: Linux
Software: Apache/2.4.10 (Unix)
MySQL version: 5.7.21
PHP Version: 7.0.19
PHP Max Input Vars: 5000
PHP Max Post Size: 1047527424
GD Installed: Yes
ZIP Installed: Yes
Write Permissions: All right
Elementor Library: Connected

== WordPress Environment ==
Version: 4.9.6
Site URL: http://demo.deothemes.com/test
Home URL: http://demo.deothemes.com/test
WP Multisite: No
Max Upload Size: 999 MB
Memory limit: 40M
Permalink Structure: Plain
Language: en-US
Timezone: 0
Debug Mode: Active

== Theme ==
Name: Margin
Version: 1.0.0
Author: DeoThemes
Child Theme: No

== User ==
Role: administrator
WP Profile lang: en_US
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36

== Active Plugins ==
Advanced WordPress Reset
Version: 1.0.1
Author: Younes JFR.

Deo Elementor Extension
	Version: 1.0.1
	Author: DeoThemes

Elementor
	Version: 2.1.1
	Author: Elementor.com

One Click Demo Import
	Version: 2.5.0
	Author: ProteusThemes

== Debug ==
Errors: There are no errors to display

</details>
@bainternet
Copy link
Contributor

bainternet commented Jul 4, 2018

@DeoThemes

can you upload the xml?

Also is the native WP importer working for you?

@bainternet bainternet added the status/needs-feedback Indicates when an Issue, Pull Request, or Discussion awaits Feedback from the poster. label Jul 4, 2018
@DeoThemes
Copy link
Author

Native WP importer seems to be working fine. So it's the conflict of recent version of Elementor and One Click Demo Import.

Here is the XML:
https://www.dropbox.com/s/oxz435plv83fqxp/demo-content.xml?dl=0

@tomusborne
Copy link

I'm also noticing this with our Site Library in GP. When an Elementor site is imported, it's importing the Elementor content without any of the section containers/HTML.

@nishant-t
Copy link

Facing the exact same issue when importing with One Click Demo Import for the latest version. Tested with 2.0.16 and it works absolutely fine. Normal WordPress Import works fine.

@tomusborne
Copy link

tomusborne commented Jul 4, 2018

So what's happening is _elementor_data is coming out of the importer as NULL.

In version 2.0.16, this data has tons of backslashes. In 2.1, those backslashes are gone. That's the only difference I'm seeing when debugging the data so far.

@tomusborne
Copy link

It did have to do with slashing.

If the metadata is ran through wp_slash(), it works in 2.1. However, this makes it fail in 2.0.16.

@bainternet Any idea what changed here? I'm happy to wp_slash() it, but want to make sure it's a permanent fix and not something I'll have to undo at some point?

@bainternet
Copy link
Contributor

@tomusborne

We are looking at it.

@bainternet bainternet added the bug Indicates a bug with one or multiple components. label Jul 5, 2018
@bainternet bainternet added the status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged. label Jul 5, 2018
KingYes added a commit that referenced this issue Jul 5, 2018
Import Fix compatibility for admin based imports closes #4947
@tomusborne
Copy link

That commit fixes the issue. Thanks for looking into this!

@SecondLineThemesHQ
Copy link

Thanks guys for providing a fix. Any idea when this would be merged into the master branch?
This bug heavily affects any theme that comes with a non-standard import process so it would be much appreciated to see the update out there sooner than later.

@arielk arielk added status/merged Indicates when a Pull Request has been merged to a Release. and removed status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged. status/needs-feedback Indicates when an Issue, Pull Request, or Discussion awaits Feedback from the poster. labels Jul 8, 2018
@KingYes KingYes closed this as completed in ce68dba Jul 8, 2018
@pulla
Copy link

pulla commented Dec 13, 2018

I still have the problem. I use the newest elementor and used WordPress import.
But still having a problem. It comes with text not elementor data.

@girisagar051
Copy link

I also have the same problem.The Global settings in the Elementor is not importing with XML file.
Is there any solution regarding this issue??

@stylethemes
Copy link

I'm facing the same problem here when importing the XML data using the one-click demo import plugin the content do get imported but global elementor settings don't example (custom breakpoints, global colors and global fonts)

is there is fix to this

@Gnodesign
Copy link

Did anybody find a fix on this? The content gets imported but the global settings do not get imported. I would appreciate if somebody could provide a solution to this. :)

@riyasrahman
Copy link

Dear all i am using one click demo import plugin. I created website with elementor pro. When i am importing the demo its emporting everything except elementor site settings and templates. How can i import xml file with elemenotor templates and site setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug with one or multiple components. status/merged Indicates when a Pull Request has been merged to a Release.
Projects
None yet
Development

No branches or pull requests