a11y: Icon Box widget accessibility #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiy
changed the title
aria-hidden="true" to the icon box widget
ramiy
changed the title
aria-hidden="true" to the icon box widget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The icon box widget need some accessibility love!
The Icon box has 3 elements:
<i>icon, the title with custom HTML tag controlled by the user, and a description paragraph in<p>.The
<i>icon is used for pure decoration or visual styling, and it should not be displayed to an assistive technology-using user. We need to addaria-hidden="true"to the markup.