Give internal presentation store an id #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeredpath
changed the title
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Apr 22, 2024
…ure to from: "1.9.3" (#1020) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture) | patch | `from: "1.9.2"` -> `from: "1.9.3"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.9.3`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.9.3) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.9.2...1.9.3) #### What's Changed - Added: Added missing `StackActionOf<R>` type alias (thanks [@​d-date](https://togithub.com/d-date), [https://github.com/pointfreeco/swift-composable-architecture/pull/2906](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2906)). - Fixed: Cache scoped presentation stores where possible (thanks [@​lukeredpath](https://togithub.com/lukeredpath), [https://github.com/pointfreeco/swift-composable-architecture/pull/2908](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2908)). - Fixed: Allow "inert" enum state to be observed by having an ever-changing ID ([https://github.com/pointfreeco/swift-composable-architecture/pull/2910](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2910)). - Fixed: Silence SwiftSyntax 510 / Xcode 15.3 warnings ([https://github.com/pointfreeco/swift-composable-architecture/pull/2909](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2909)). - Fixed: Restore `TestStore` autocompletion ([https://github.com/pointfreeco/swift-composable-architecture/pull/2923](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2923)). - Fixed: It is now possible to scope bindings of enum stores to non-reducer cases for sheets and other navigation ([https://github.com/pointfreeco/swift-composable-architecture/pull/2943](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2943)). - Fixed: `package` access modifier support in enum `@Reducer` macro (thanks [@​samrayner](https://togithub.com/samrayner), [https://github.com/pointfreeco/swift-composable-architecture/pull/2939](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2939)). - Fixed: `Effect.publisher` is no longer escaping ([https://github.com/pointfreeco/swift-composable-architecture/pull/2968](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2968)). - Fixed: Add runtime warning diagnostic to catch nested calls to `observe` ([https://github.com/pointfreeco/swift-composable-architecture/pull/2996](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2996)). - Infrastructure: Fix documentation typos (thanks [@​takehilo](https://togithub.com/takehilo), [https://github.com/pointfreeco/swift-composable-architecture/pull/2898](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2898); [https://github.com/pointfreeco/swift-composable-architecture/pull/2944](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2944)); tutorial fixes (thanks [@​LRSnowX](https://togithub.com/LRSnowX), [https://github.com/pointfreeco/swift-composable-architecture/pull/2808](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2808)); test store tutorial/documentation fixes ([https://github.com/pointfreeco/swift-composable-architecture/pull/2912](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2912)); fix favorites case study mocks (thanks [@​beribas](https://togithub.com/beribas), [https://github.com/pointfreeco/swift-composable-architecture/pull/2962](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2962)); improve docs for stack-based navigation ([https://github.com/pointfreeco/swift-composable-architecture/pull/2967](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2967)); fix dismissal in UIKit demos ([https://github.com/pointfreeco/swift-composable-architecture/pull/2986](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2986)) fix shared state case study (thanks [@​eltociear](https://togithub.com/eltociear), [https://github.com/pointfreeco/swift-composable-architecture/pull/2994](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2994)). #### New Contributors - [@​LRSnowX](https://togithub.com/LRSnowX) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2808](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2808) - [@​beribas](https://togithub.com/beribas) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2962](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2962) - [@​samrayner](https://togithub.com/samrayner) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2939](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2939) - [@​eltociear](https://togithub.com/eltociear) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2994](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2994) **Full Changelog**: pointfreeco/swift-composable-architecture@1.9.2...1.9.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the problem raised in #2907 where using legacy presentation APIs (e.g.
sheet(store:)) result in the presented destination always receiving a store that does not support store caching due to the hardcodednilID given to the internal store that is created.This prevents you from presenting features that uses observation tools using these APIs without lots of purple runtime warnings even though there's no reason why you shouldn't be able to do this.
Note: An earlier implementation in of this logic used to have a comment stating that a
\.selfID could not be used because it would prevent dismissal. In my example app I am able to present and dismiss sheets using both the SwiftUIdismissenvironment value, or by sending an action to the store and setting the destination state tonil.