Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set box transparency #41

Closed
wants to merge 1 commit into from
Closed

Conversation

PierreGtch
Copy link
Contributor

Closes #40

@pog87
Copy link
Owner

pog87 commented Oct 10, 2023

Hi @PierreGtch, thanks for your effort.

I get your point of tweaking the boxplot's alpha (only the box, this way). I tried your code and realized that some people would not like to use the same alpha for kde and box.

I propose the following: when scanning for kwargs under box elif "box_" in key: add an if statement for the alpha kwarg and add it to the boxprops using update method. This way one could call box_alpha separately.

does this make sense to you?

@pog87 pog87 closed this Oct 10, 2023
@PierreGtch
Copy link
Contributor Author

Then I would rather scan for box_boxprops and update boxprops with it. It would allow to stay consistent with the seaborn API and also to overwrite the boxprops argument. What do you think?

@pog87
Copy link
Owner

pog87 commented Oct 13, 2023

that sounds nice. the boxprops is going to get updated and not overwritten, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box's alpha parameter
2 participants