Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Error Enum to node-fetch #160

Open
lautarodragan opened this issue Jun 18, 2018 · 0 comments
Open

Introduce Error Enum to node-fetch #160

lautarodragan opened this issue Jun 18, 2018 · 0 comments
Assignees
Labels

Comments

@lautarodragan
Copy link
Member

Creating this issue to track the work done, even though part of the work will be done in another repo.

// TODO: make PR to node-fetch with this enum
export enum FetchErrorType {
RequestTimeout = 'request-timeout',
BodyTimeout = 'body-timeout',
System = 'system',
NoRedirect = 'no-redirect',
MaxRedirect = 'max-redirect',
UnsupportedRedirect = 'unsupported-redirect',
MaxSize = 'max-size',
InvalidJson = 'invalid-json',
}

Will also need to delete the enum from our code base and import node-fetch's one if the PR gets accepted and published.

Will try and tackle this one next Friday, as it's not immediately critical to our progress but something I'd like to see.

@lautarodragan lautarodragan self-assigned this Jun 18, 2018
@geoffturk geoffturk removed the planned label Oct 10, 2018
@geoffturk geoffturk modified the milestone: Mainnet-launch Nov 28, 2018
@geoffturk geoffturk added ct-z and removed ct-z labels Nov 29, 2018
@geoffturk geoffturk modified the milestones: Mainnet-launch, PML2 Nov 29, 2018
@lautarodragan lautarodragan removed this from the PML2 milestone Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants