Poem crash during f64 parsing

[rxdiscovery]

Hello,

Recently, an application made with Poem crashed when sending JSON responses.

I investigated and found the cause:

thread 'tokio-runtime-worker' panicked at /home/XXXXX/.cargo/registry/src/index.crates.io-6f17d22XXXXXXX/poem-openapi-5.1.0/src/types/external/floats.rs:91:1:

It is this macro that is behind the exception :

impl_type_for_floats!((f32, "float"), (f64, "double"));

analyzing the code generated by this macro, I find the culprit:

       impl ToJSON for $ty {
            fn to_json(&self) -> Option<Value> {
                Some(Value::Number(Number::from_f64(*self as f64).unwrap())) //<----- UNWRAP <<<<
            }
        }

there's an “unwrap()” in the code (src/types/external/floats.rs), the exception is not handled.

In a post about a year ago, I pointed out the presence of several unwrap() functions in the Poem project source code. The unwrap() / except() functions should never be used in production code.

several files in src/types/external/ contain unwrap() :

• array.rs
• bson.rs
• float.rs
• time.rs

Thank you for all your efforts behind this framework. 👍

Specifications

• Version: 3.1.0

[sunli829]

Thanks for the bug report, I fixed it except for array.rs. Since I checked the length, the try_into there couldn't possibly fail.

[sunli829]

released in v5.1.1

[rxdiscovery]

@sunli829 Thank you very much for your responsiveness 🥇