1187 - made all the profile links to redirect to /profile/donations #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachar
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Thanks, @AnzheloD for bringing that up, and @dimitur2204 for making it happen. 🚀
kachar
deleted the
1187-refix-problem-with-translations-on-my-profile-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again regarding #1187
After @AnzheloD pointed out he had the error again and the
redirectin thenext.config.jsis only a server side redirect and didn't do anything about client side routing.In this PR I changed it so now there is not index page for the
profile,All the routes that were leading to the index now lead to
/profile/donationswhich to me makes more sense considering we have the tabbing functionality which also changes routes.Testing
Trying refreshing, logging in, out again! Seems to be consistent!
Affected urls