[Fix] - Translations on the profile page #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitur2204
changed the title
kachar
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Nice catch @dimitur2204
Thanks for following this rabbit hole till the end 🕳️ 🐇
kachar
deleted the
1187-bug-problem-with-translations-on-my-profile-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1187.
Removed a redirect in the
next.config.jsMotivation and context
Seems like the redirect bugged out the server side translations somehow. The redirect was supposed to redirect to
/profile/donations, which is the first Tab on the page, but it does seem to work fine without the redirect.Screenshots:
Testing
Tried logging out and in, clearing the cache, refreshing and it always seemed to translate.
Affected urls
Affected:
/profilewhen you are logged in.