Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Create confirmation modal according to discussion #697

Open
kachar opened this issue Apr 10, 2022 · 2 comments · Fixed by #653 or #728
Open

[Feature] Create confirmation modal according to discussion #697

kachar opened this issue Apr 10, 2022 · 2 comments · Fixed by #653 or #728
Labels
help wanted Extra attention is needed

Comments

@kachar
Copy link
Member

kachar commented Apr 10, 2022

Is your feature request related to a problem? Please describe.
We've discussed a specific approach for handling confirmations for deletions and now it's time to actually implement it

Describe the solution you'd like
Please develop the discussed functionality from #567 (comment)

@ani-kalpachka
Copy link
Member

Is this functionality already implemented?

@kachar
Copy link
Member Author

kachar commented Aug 23, 2022

I see this has been implemented in the codebase as ConfirmationDialog and useConfirm hook

https://github.com/podkrepi-bg/frontend/blob/master/src/components/common/ConfirmationDialog.tsx

https://github.com/podkrepi-bg/frontend/blob/master/src/common/hooks/useConfirm.ts

What might be left is to use these components in the delete modals and replace the ModalStore implementations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
2 participants