Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The images on 'Completed campaigns' section are not responsive #1594

Closed
ani-kalpachka opened this issue Sep 17, 2023 · 2 comments
Closed

The images on 'Completed campaigns' section are not responsive #1594

ani-kalpachka opened this issue Sep 17, 2023 · 2 comments
Labels
area: frontend type: bug Something isn't working

Comments

@ani-kalpachka
Copy link
Member

ani-kalpachka commented Sep 17, 2023 •
edited
Loading

Which area(s) of Podkrepi.bg are affected?

Homepage

Describe the Bug

The UI for the cards on 'Completed campaigns' carousel seems to be displaced.

  • For mobile devices the images are cut:
    image

  • For tablets they are not centered:
    image

To Reproduce

  1. Open the homepage.
  2. Scroll down to 'Completed campaigns' section.
  3. Switch to responsive view.

Expected Behavior

The images have to be responsive.

Which browser are you using? (if relevant)

Tested on Chrome and Firefox
@ani-kalpachka ani-kalpachka added type: bug Something isn't working area: frontend labels Sep 17, 2023
@sashko9807
Copy link
Member

The images in tablet/mobile view should be fixed in 1592.

As for the images being cut, objectFit property could be removed, but imho it seems to retain the image quality better in this case.

@ani-kalpachka
Copy link
Member Author

I retested again. It it fixed. Thank you @sashko9807!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: frontend type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ani-kalpachka @sashko9807