Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Remove whitespaces from IBAN #1109

Closed
imilchev opened this issue Nov 16, 2022 · 2 comments · Fixed by #1141
Closed

[Feature] Remove whitespaces from IBAN #1109

imilchev opened this issue Nov 16, 2022 · 2 comments · Fixed by #1141
Assignees
Labels
good first issue Good for newcomers

Comments

@imilchev
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When contributing to a campaign via bank transfer the IBAN of the organization is shown. It, currently, contains whitespaces which cause issues when copy-pasting it into online banking. To ease users, we should remove the whitespaces.

Describe the solution you'd like
Remove the whitespaces from the IBAN:
image

@imilchev imilchev added the good first issue Good for newcomers label Nov 16, 2022
@valkirilov
Copy link
Contributor

@imilchev I see that this behavior is causing issues when people copy/paste the IBAN, but we must admit that it's looking better (and way more easier) if you read and type manually when there are such "blank space" separators.

So, how about applying this change only to the IBAN when you use the "Copy" button?

  • keep the visuals of the IBAN as it is now, with spaces to separate each portion
  • trim automatically the spaces before putting the IBAN it into the clipboard when you use the "Copy" button next to it

@igoychev
Copy link
Contributor

I support the trimming to be on the copy button, and leave the text with spaces.

@AnzheloD AnzheloD self-assigned this Nov 20, 2022
@AnzheloD AnzheloD linked a pull request Nov 20, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants