1087 feature add ability to assign legal entitycompany as organizer #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success180 tests passing in 64 suites. Report generated by 🧪jest coverage report action from d9c3a0b |
kachar
reviewed
Nov 17, 2022
1 task
kachar
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Once again an awesome contribution @dimitur2204
I can't see anything that can be improved around the code.
In your question - we're using toEntity so we can encapsulate which field are used to connect to external entity in the db. We validate the input uuids and link them annoyingly to reduce the duplication and reuse the code. The relation objects are a pattern that we couldn't validate enough to make sure we're consistent with it everywhere. The other approach seems to be more simplistic for the time being as the frontend doesn't have to know the proper json to match the Prisma linking style.
dimitur2204
deleted the
1087-feature-add-ability-to-assign-legal-entitycompany-as-organizer
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add
company_idfield on the campaign regarding #1087 with a relation to the company field.Notes
I noticed that sometimes we have these Relation objects and sometimes we don't
Here we have it:
And on this PR for example for the
campaignwe instead have atoEntity()function that seems to connect the fields:Is there a difference?