Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder link broken? #13

Open
rabernat opened this issue Dec 2, 2020 · 2 comments
Open

Binder link broken? #13

rabernat opened this issue Dec 2, 2020 · 2 comments

Comments

@rabernat
Copy link

rabernat commented Dec 2, 2020

I'm very excited about this tutorial and would love to help however I can.

Perhaps this issue is premature, as the tutorial is still under development, but I thought I would just mention it.

The binder link in the README is as follow: https://aws-uswest2-binder.pangeo.io/v2/gh/podaac/AGU-2020/main?urlpath=git-pull?repo=https://github.com/podaac/AGU-2020%26amp%3Burlpath=lab/tree/main

After building, JupyterLab redirected me to this url:
https://hub.aws-uswest2-binder.pangeo.io/user/podaac-agu-2020-z0hpn0kk/git-pull?repo=https://github.com/podaac/AGU-2020&urlpath=lab/tree/main
Which produced a 404

I think the problem is that you don't have nbgitpuller installed in your image. Here is a working link that uses the pangeo default-binder image with your repo contents. This avoids the need to specify a custom environment.

https://aws-uswest2-binder.pangeo.io/v2/gh/pangeo-gallery/default-binder/53de928?urlpath=git-pull?repo=https://github.com/podaac/AGU-2020%26amp%3Bbranch=main%26amp%3Burlpath=lab/tree/AGU-2020

Putting these binder links together can be quite confusing, so let me know if I can help.

@betolink
Copy link

betolink commented Dec 2, 2020

Hi Ryan, thanks for reporting this. I'm about to open a PR that will fix the link using an environment on a separate branch(like Scott recommended)

@betolink
Copy link

betolink commented Dec 2, 2020

I think the links should work fine now @rabernat on a separate issue, @asteiker ran into a bug with intake-stac and s3 locations intake/intake-stac#48 we're going to test pystac but I'm not sure if we'll have enough time to implement a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants