Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Poco::Process::launch (UNIX) - memory leak when launching invalid command #4267

Conversation

pavledragisic
Copy link
Member

No description provided.

Copy link
Member

@aleks-f aleks-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Foundation/src/Process_UNIX.cpp Outdated Show resolved Hide resolved
Foundation/src/Process_UNIX.cpp Outdated Show resolved Hide resolved
@aleks-f aleks-f merged commit 5e88502 into devel Nov 21, 2023
18 checks passed
@aleks-f aleks-f deleted the 2366-pocoprocesslaunch-unix-possible-memory-leak-when-launching-invalid-command branch November 21, 2023 02:04
aleks-f pushed a commit that referenced this pull request Nov 23, 2023
… command (#4267)

* fix: memory leak in ProcessImpl  #2366

* fix(Process): variable masking and spelling #2366

* feat(ProcessTest): invalid command launch test #2366

* fix(ProcessTest): handle failed launch on win #2366

* fix(ProcessTest): undefined exception #2366

---------

Co-authored-by: Pavle <[email protected]>
aleks-f pushed a commit that referenced this pull request Nov 27, 2023
… command (#4267)

* fix: memory leak in ProcessImpl  #2366

* fix(Process): variable masking and spelling #2366

* feat(ProcessTest): invalid command launch test #2366

* fix(ProcessTest): handle failed launch on win #2366

* fix(ProcessTest): undefined exception #2366

---------

Co-authored-by: Pavle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poco::Process::launch (UNIX) - possible memory leak when launching invalid command
2 participants