build Poco Net failed MinGW [TIMESTAMP_REQUEST enum vs macro]

[sk-landry]

Good morning,

I'm building POCO from Github's master branch. (commit = 3fc3e5f)
I use MinGW 7.3 32bits bundled in QT. I am on Windows 10.
The build of POCO NET failed because of the enum TIMESTAMP_REQUEST define in ICMPv4PackekImpl.h

enum MessageType
{
TIMESTAMP_REQUEST ,
};

The error indicates that there is a macro TIMESTAMP_REQUEST define somewhere, I don't know where but it is causing a conflict

My solution was to rename the enum from TIMESTAMP_REQUEST to simply TIMESTAMP.

For information, I've previously built POCO 1.9.0-release without any issues with the same environment.

[iSLC]

It conflicts with a macro named TIMESTAMP_REQUEST inside the wincrypt.h header.

#define TIMESTAMP_REQUEST ((LPCSTR) 78)

EDIT: My solution was to basically get rid of it for the duration of that enum.

	// wincrypt.h also contains a macro named TIMESTAMP_REQUEST
	// being a MinGW issue we can get rid of it for a moment
#if defined(TIMESTAMP_REQUEST) && defined(POCO_COMPILER_MINGW)
	#pragma push_macro("TIMESTAMP_REQUEST")
	#define POCO_RESTORE_TIMESTAMP_REQUEST
	#undef TIMESTAMP_REQUEST
#endif

	enum MessageType
	{
		//...
		TIMESTAMP_REQUEST,
		//...
	};

#if defined(POCO_RESTORE_TIMESTAMP_REQUEST)
	#pragma pop_macro("TIMESTAMP_REQUEST")
	#undef POCO_RESTORE_TIMESTAMP_REQUEST
#endif

Note however that you need this fix to know if you're under MinGW #3195

Looks weird but you work with what you can.

[github-actions]

This issue is stale because it has been open for 365 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 60 days since being marked as stale.

[matejk]

When trying to compile with MinGW 11 there are more compile issues with current state of devel.

Will fix and create pull request.