fix(VarHolder): limits check

pocoproject · Jun 27, 2022 · c377807 · c377807
1 parent 309aff3
commit c377807
Showing 1 changed file with 7 additions and 15 deletions.
diff --git a/Foundation/include/Poco/Dynamic/VarHolder.h b/Foundation/include/Poco/Dynamic/VarHolder.h
@@ -410,16 +410,15 @@ class Foundation_API VarHolder
 	template <typename F, typename T>
 	void checkUpperLimit(const F& from) const
 	{
-		if ((sizeof(T) < sizeof(F)) &&
-			(from > static_cast<F>(std::numeric_limits<T>::max())))
-		{
-			throw RangeException("Value too large.");
-		}
-		else
 		if (from > std::numeric_limits<T>::max())
-		{
 			throw RangeException("Value too large.");
-		}
+	}
+
+	template <typename F, typename T>
+	void checkLowerLimit(const F& from) const
+	{
+		if (from < std::numeric_limits<T>::min())
+			throw RangeException("Value too small.");
 	}
 
 	template <typename F, typename T>
@@ -453,13 +452,6 @@ class Foundation_API VarHolder
 				throw RangeException("Value too small.");
 		}
 	}
-
-	template <typename F, typename T>
-	void checkLowerLimit(const F& from) const
-	{
-		if (from < std::numeric_limits<T>::min())
-			throw RangeException("Value too small.");
-	}
 };