Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown elements' children are treated the same as direct children of the svg element #118

Closed
cysp opened this issue Mar 22, 2018 · 2 comments

Comments

@cysp
Copy link
Contributor

cysp commented Mar 22, 2018

Steps to reproduce the issue

  1. Load an SVG that has a svg:mask element
  2. Observe that the mask's path is rendered as though it was an element of the image

Specifications

  • PocketSVG Version: HEAD
  • Xcode Version: 9.x
  • iOS/macOS Version: iOS 11.x

To get myself out of trouble, I've implemented some logic to just ignore unknown elements here:
master...cysp:feature/ignore-unknown-elements
… is that something that you would consider taking upstream or would you want to wait for a change that properly respects the mask?

@arielelkin
Copy link
Collaborator

Hi again, @cysp 🙂

I think ignoring unknown elements makes sense.

@fjolnir are you ok with this approach ?

This would also a good opportunity to clearly document which SVG elements can be rendered and which ones will be ignored.

@arielelkin
Copy link
Collaborator

closed via #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants