Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different Rain Values if It Rains between 23:55 and 00:00 #685

Open
roe-dl opened this issue May 14, 2021 · 18 comments
Open

Different Rain Values if It Rains between 23:55 and 00:00 #685

roe-dl opened this issue May 14, 2021 · 18 comments
Labels
bug Something isn't working

Comments

@roe-dl
Copy link
Contributor

roe-dl commented May 14, 2021

Describe the bug
If it rains between 23:55 and 00:00, the rain value displayed in the station observation section is different from the rain value displayed in snapshots section of the home page.

I did some debugging and found that hint in the WeeWX comments regarding dayRain:

                # NB: The WU considers the archive with time stamp 00:00
                # (midnight) as (wrongly) belonging to the current day
                # (instead of the previous day). But, it's their site,
                # so we'll do it their way.  That means the SELECT statement
                # is inclusive on both time ends:

So dayRain (which is sent by MQTT) is calculated different than $day.rain.sum:

  • dayRain: 23:55:01 up to now
  • $day.rain.sum: 00:00:01 up to now

The correct value is the latter.

Link to your website (IMPORTANT)
https://www.woellsdorf-wetter.de

Version of the skin you're using
1.2

To Reproduce
You need to wait for a day when it rains between 23:55:01 and 00:00:00. Then you see the problem without further action.

Expected behavior
The daily rain is to be calculated for the time range from 00:00:01 up to now.

Device Information (please complete the following information):

  • Device: independent of device
  • OS: independent of OS
  • Browser: indepentend of Browser
  • Version: not applicable

Additional context
I guess the solution involves introducing a second observation type for daily rain. That could be implemented by an XType extension. Such an XType extension value would be included in the MQTT output automatically.

HELP WANTED
I could try to write a fix for that, but I would do so on request only, as it is some work to do.

@roe-dl roe-dl added the bug Something isn't working label May 14, 2021
@stale
Copy link

stale bot commented Aug 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had activity label Aug 12, 2021
@roe-dl
Copy link
Contributor Author

roe-dl commented Aug 13, 2021

The problem still persists. And I think the reason is in the special behavior of dayRain. What do you think?

@stale stale bot removed the stale Issue has not had activity label Aug 13, 2021
@roe-dl
Copy link
Contributor Author

roe-dl commented Sep 13, 2021

It is still open.

@stale
Copy link

stale bot commented Dec 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had activity label Dec 12, 2021
@roe-dl
Copy link
Contributor Author

roe-dl commented Dec 13, 2021

The problem is still there.

@stale stale bot removed the stale Issue has not had activity label Dec 13, 2021
@stale
Copy link

stale bot commented Mar 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had activity label Mar 13, 2022
@roe-dl
Copy link
Contributor Author

roe-dl commented Mar 16, 2022

Still actual

@roe-dl
Copy link
Contributor Author

roe-dl commented Apr 19, 2022

See matthewwall/weewx-mqtt#31

@stale
Copy link

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had activity label Jul 30, 2022
@roe-dl
Copy link
Contributor Author

roe-dl commented Jul 31, 2022

The PR I issued to weewx-mqtt is still not recognized by Matthew. So this is still actual.

@stale stale bot removed the stale Issue has not had activity label Jul 31, 2022
@stale
Copy link

stale bot commented Nov 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had activity label Nov 1, 2022
@roe-dl
Copy link
Contributor Author

roe-dl commented Nov 1, 2022

See matthewwall/weewx-mqtt#33

Matthew is not sure he will include the PR into the MQTT extension. If not, a solution inside the Belchertown skin is required.

@stale stale bot removed the stale Issue has not had activity label Nov 1, 2022
@stale
Copy link

stale bot commented Feb 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had activity label Feb 12, 2023
@roe-dl
Copy link
Contributor Author

roe-dl commented Feb 12, 2023

There are no news about the weewx-mqtt extension. The problem persists.

@stale stale bot removed the stale Issue has not had activity label Feb 12, 2023
@stale
Copy link

stale bot commented May 20, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had activity label May 20, 2023
@roe-dl
Copy link
Contributor Author

roe-dl commented May 21, 2023

There are no news about the weewx-mqtt extension. The problem persists.

@stale stale bot removed the stale Issue has not had activity label May 21, 2023
@stale
Copy link

stale bot commented Sep 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had activity label Sep 16, 2023
@roe-dl
Copy link
Contributor Author

roe-dl commented Sep 18, 2023

There are no news about the weewx-mqtt extension. The problem persists.

See also https://github.com/chaunceygardiner/weewx-rain24h

@stale stale bot removed the stale Issue has not had activity label Sep 18, 2023
Repository owner deleted a comment from Soumya6Tiwari Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant