Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace failure (which is deprecated) with thiserror #106

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Replace failure (which is deprecated) with thiserror #106

merged 1 commit into from
Dec 16, 2020

Conversation

madadam
Copy link
Contributor

@madadam madadam commented Dec 9, 2020

Closes #105

afck
afck approved these changes Dec 13, 2020
View reviewed changes
Copy link
Collaborator

@afck afck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, if @igorbarinov is okay with it. 👍

@igorbarinov
Copy link
Member

Looks good to me, if @igorbarinov is okay with it. 👍

✅

@afck afck merged commit a7fbfa4 into poanetwork:master Dec 16, 2020
@grumbach grumbach mentioned this pull request Jun 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afck afck afck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failure is deprecated. Consider switching to thiserror (or similar)
3 participants
@madadam @igorbarinov @afck