Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some agreement logic into submodules. #175

Open
afck opened this issue Jul 30, 2018 · 2 comments
Open

Move some agreement logic into submodules. #175

afck opened this issue Jul 30, 2018 · 2 comments

Comments

@afck
Copy link
Collaborator

afck commented Jul 30, 2018

The Agreement implementation is pretty convoluted, even though some parts of it could be split out and have a somewhat well-defined contract by themselves. E.g. the BVal round is called "Binary-value Broadcast", and together with Aux "Synchronized Binary-value Broadcast" in https://hal.archives-ouvertes.fr/hal-01176110/document.

Maybe we should also factor out AgreementEpoch, to split the epoch management and dispatching from the main part of the logic, and to avoid clearing all those fields individually. (That makes it easy to forget one.)

@c0gent
Copy link
Contributor

c0gent commented Jul 30, 2018

I'd love to see this API refined and clarified :)

@afck
Copy link
Collaborator Author

afck commented Aug 9, 2018

Unassigning but not closing this for now.
It would be good to make a decision about #198 before we continue with refactoring this module.

@afck afck removed their assignment Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants