Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce API_PATH env var #2989

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Introduce API_PATH env var #2989

merged 1 commit into from
Jan 30, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jan 29, 2020

Motivation

If Blockscot instance is proxied to blockscout.com there are 2 problems exist:

  • URL on API docs page doesn't include path on blockscout.com for the instance that confusing developers
  • Try it out section doesn't work for ETH RPC API endpoints

Changelog

API_PATH ENV var introduced which indicates the path for API URL. If it is not set, it is /.

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Jan 29, 2020
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Jan 29, 2020
@coveralls
Copy link

coveralls commented Jan 29, 2020

Pull Request Test Coverage Report for Build a5486d9f-6237-47d0-8ee4-8d56bd4cafe5

  • 4 of 7 (57.14%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 75.313%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/api_docs_view.ex 4 5 80.0%
apps/block_scout_web/lib/block_scout_web/views/tokens/instance/overview_view.ex 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build 403d0cf5-4417-4757-8b1b-65692cb5992e: -0.02%
Covered Lines: 5415
Relevant Lines: 7190

💛 - Coveralls

@vbaranov vbaranov merged commit ba0e111 into master Jan 30, 2020
@vbaranov vbaranov deleted the vb-fix-eth-rpc-api-path branch January 30, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants