Move socket path to env #2955
Merged
Move socket path to env #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 136621bd-d2ed-49b2-8f33-f334d65bc95d
💛 - Coveralls |
vbaranov
reviewed
Jan 16, 2020
There was a problem hiding this comment.
@maxaleks please create also a separate PR to extend the table with this new ENV var https://github.com/blockscout/docs/blob/master/for-developers/information-and-settings/env-variables.md. Fill version column with master. A new record should e at the bottom.
|
@vbaranov Done ✅ |
vbaranov
requested changes
Jan 17, 2020
| @@ -1,7 +1,7 @@ | |||
| import { Socket } from 'phoenix' | |||
| import { locale } from './locale' | |||
|
|
|||
| const socket = new Socket('/socket', { params: { locale: locale } }) | |||
| const socket = new Socket((process.env.SOCKET_ROOT || '') + '/socket', { params: { locale: locale } }) | |||
There was a problem hiding this comment.
@maxaleks websocket should work fine (the same way when there is no ENV var) if to set export SOCKET_ROOT=/ but it doesn't work
vbaranov
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2948