Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API endpoint: sum of balances except burning address #2926

Merged
merged 3 commits into from
Dec 31, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Dec 19, 2019

Motivation

A new endpoint to get a sum of the balances except burning address. Returns just a value.

/api?module=stats&action=coinsupply

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-api-endpoint-sum-balances-minus-burnt branch from 4e90770 to 5028ba2 Compare December 19, 2019 15:01
@coveralls
Copy link

coveralls commented Dec 19, 2019

Pull Request Test Coverage Report for Build 7e4edc74-3e66-4efc-a79a-3522f90ec200

  • 0 of 18 (0.0%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 74.88%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/api/rpc/stats_view.ex 0 1 0.0%
apps/block_scout_web/lib/block_scout_web/views/api/rpc/rpc_view.ex 0 2 0.0%
apps/block_scout_web/lib/block_scout_web/controllers/api/rpc/stats_controller.ex 0 3 0.0%
apps/explorer/lib/explorer/chain.ex 0 3 0.0%
apps/explorer/lib/explorer/chain/cache/address_sum_minus_burnt.ex 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/views/api/rpc/stats_view.ex 1 80.0%
apps/block_scout_web/lib/block_scout_web/controllers/api/rpc/stats_controller.ex 2 70.59%
Totals Coverage Status
Change from base Build 29f6f9c7-2348-4152-a9f0-6e4908fc977c: -0.2%
Covered Lines: 5300
Relevant Lines: 7078

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-api-endpoint-sum-balances-minus-burnt branch from 5028ba2 to af30e4a Compare December 19, 2019 15:15
@vbaranov vbaranov self-assigned this Dec 19, 2019
@vbaranov vbaranov changed the title API endpoint: sum balances except burnt address API endpoint: sum balances except burning address Dec 19, 2019
@vbaranov vbaranov changed the title API endpoint: sum balances except burning address API endpoint: sum of balances except burning address Dec 19, 2019
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Dec 19, 2019
@vbaranov vbaranov force-pushed the vb-api-endpoint-sum-balances-minus-burnt branch from af30e4a to 5e0a470 Compare December 19, 2019 15:29
@vbaranov vbaranov merged commit 7d89de6 into master Dec 31, 2019
@vbaranov vbaranov deleted the vb-api-endpoint-sum-balances-minus-burnt branch December 31, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants