Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check fetched instance metadata in multiple places #2900

Merged
merged 2 commits into from
Dec 11, 2019
Merged

check fetched instance metadata in multiple places #2900

merged 2 commits into from
Dec 11, 2019

Conversation

ayrat555
Copy link
Contributor

Changelog

  • check fetched instance metadata in multiple places

@coveralls
Copy link

coveralls commented Nov 29, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build faf06531-dfe9-4090-866d-cea6bf4cb296

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 75.089%
Totals Coverage Status
Change from base Build 47c68183-e0ed-4b80-951e-be27e4e5c892: 0.004%
Covered Lines: 5281
Relevant Lines: 7033
💛 - Coveralls

@vbaranov vbaranov self-requested a review December 3, 2019 09:23
@vbaranov vbaranov merged commit acb5134 into master Dec 11, 2019
@vbaranov vbaranov deleted the ab-use-check-type-in-multiple-places branch December 11, 2019 10:08
@enlight enlight mentioned this pull request Jan 22, 2020
Merged
enlight added a commit to loomnetwork/blockscout that referenced this pull request Jan 22, 2020
@enlight
Backport a couple of fixes from upstream (#77)
4db6f0f 
Cherry-picked a couple of fixes from upstream:
- blockscout/blockscout#2900) - check fetched instance metadata in multiple places
- blockscout/blockscout#2899 - fix empty buffered task

The first one should get rid of these errors in the logs:

** (MatchError) no match of right hand side value: {:error, #Ecto.Changeset<action: :insert, changes: %{token_contract_address_hash: %Explorer.Chain.Hash{byte_count: 20, bytes: <<154, 184, 21, 82, 215, 18, 29, 147, 131, 80, 1, 99, 43, 16, 142, 137, 184, 89, 116, 43>>}, token_id: #Decimal<158456326448928531812676815925>}, errors: [metadata: {"is invalid", [type: :map, validation: :cast]}], data: #Explorer.Chain.Token.Instance<>, valid?: false>}

And the second one will hopefully make the catch-up indexer a bit more reliable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayrat555 @coveralls @vbaranov