Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate indexes #2897

Merged
merged 3 commits into from
Jan 28, 2020
Merged

remove duplicate indexes #2897

merged 3 commits into from
Jan 28, 2020

Conversation

ayrat555
Copy link
Contributor

PGHero found duplicate indexes


Details
--
On address_token_balancesaddress_token_balances_block_number_index (block_number) is covered by address_token_balances_block_number_address_hash_index (block_number, address_hash)
On token_instancestoken_instances_token_id_index (token_id) is covered bytoken_instances_pkey (token_id, token_contract_address_hash)

@coveralls
Copy link

coveralls commented Nov 28, 2019

Pull Request Test Coverage Report for Build c7fe77e0-943f-4487-9dbb-c11f5c905e6a

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 76 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-1.05%) to 75.1%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/http/httpoison.ex 1 0.0%
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/case/parity/http_websocket.ex 1 0.0%
apps/indexer/lib/indexer/transform/addresses.ex 1 75.0%
apps/indexer/lib/indexer/block/fetcher.ex 3 83.13%
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/web_socket/case/parity.ex 4 0.0%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/http.ex 12 52.0%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/web_socket/web_socket_client.ex 53 11.25%
Totals Coverage Status
Change from base Build 9b831152-1f8d-4300-9c6d-152576bd110c: -1.05%
Covered Lines: 5281
Relevant Lines: 7032

💛 - Coveralls

@vbaranov vbaranov self-requested a review January 10, 2020 11:15
@vbaranov vbaranov merged commit c450a88 into master Jan 28, 2020
@vbaranov vbaranov deleted the ab-remove-duplicate-token-indexes branch January 28, 2020 13:20
@vbaranov vbaranov mentioned this pull request Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants