Increase chart loading speed #2887

maxaleks · 2019-11-28T13:37:32Z

I moved all logic of charts to a separate script

For production: add network prefix to key value of local storage here and here, and for session storage here and here

coveralls · 2019-11-28T13:47:08Z

Pull Request Test Coverage Report for Build 8c27aab2-b949-4e8e-95b3-43112c5dacd1

Files with Coverage Reduction	New Missed Lines	%
apps/explorer/lib/explorer/counters/average_block_time.ex	1	92.0%
apps/explorer/lib/explorer/chain/block.ex	2	57.14%
apps/block_scout_web/lib/block_scout_web/views/api/rpc/contract_view.ex	3	88.46%
apps/explorer/lib/explorer/token/instance_metadata_retriever.ex	3	46.15%
apps/indexer/lib/indexer/buffered_task.ex	8	86.57%
apps/indexer/lib/indexer/fetcher/internal_transaction.ex	21	60.32%
apps/explorer/lib/explorer/chain.ex	44	78.61%

Totals
Change from base Build 2d23a0c7-6eac-4f75-b923-04e5d838c1ed:	1.05%
Covered Lines:	5356
Relevant Lines:	7032

move chart initial loading to separate file

c5ba8e7

maxaleks requested a review from vbaranov November 28, 2019 13:37

maxaleks added 4 commits November 28, 2019 16:51

fix linter errors

f06bca3

update internalization files

d04303f

move all chart logic to separate script

77535a8

update internalization files

d75d063

vbaranov added the UI label Nov 29, 2019

maxaleks added 7 commits December 2, 2019 14:12

comment unused code

0a0eace

add setDataToLocalStorage function

76145a5

load chart script only where it's used

fc8109f

hide loading after chart script is loaded

2f0d06a

disable chart animation after the first loading

fc8ce8f

update internalization files

992a7f0

remove chart loader

b0f74f4

maxaleks force-pushed the improve-chart-loading-speed branch from 1450164 to b0f74f4 Compare December 23, 2019 16:15

vbaranov approved these changes Dec 24, 2019

View reviewed changes

vbaranov merged commit c9bdc19 into master Dec 24, 2019

vbaranov deleted the improve-chart-loading-speed branch December 24, 2019 09:29