-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pending blocks ops #2886
Merged
Merged
pending blocks ops #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: a lot of problems are created by tracking the importing progress on multiple tables. Querying and updating involves as such heavy operations and this is also the cause for inconsistencies. Solution: use a new table to track the progress of block's data indexing. By using a specific table, whose rows are deleted when there are no more pending operations on the relative block, we make joins quick and keep them to a minimum. This is also meant to simplify all inserts and updates and only perform deletes when strictly necessary.
Problem: a lot of problems are created by tracking the importing progress on multiple tables. Querying and updating involves as such heavy operations and this is also the cause for inconsistencies. Solution: use a new table to track the progress of block's data indexing. By using a specific table, whose rows are deleted when there are no more pending operations on the relative block, we make joins quick and keep them to a minimum. This is also meant to simplify all inserts and updates and only perform deletes when strictly necessary.
Pull Request Test Coverage Report for Build 4d96dd8c-7568-4c8d-9edb-3bf9ee38f98f
💛 - Coveralls |
…lidation remove pending ops on invalidation
This was referenced Nov 30, 2019
…-log do no remove non-consensus logs
…lock-ops-by-schedule clean reorgs in pending block ops by schedule
ayrat555
force-pushed
the
pp-pending-blocks-ops
branch
from
December 15, 2019 12:32
70fcb84
to
764a95c
Compare
…etch_internal_transactions
Mitigate issues in the migration to "block_hash" indexing approach
…-int-txs-to-fetch-query Speedup pending block ops int txs to fetch query
…sts in migrations now
…uery Speedup address to logs query
vbaranov
approved these changes
Dec 31, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rebased version of #2819
Motivation
A lot of problems are created by tracking the importing progress on multiple tables.
Querying and updating involves as such heavy operations and this is also the cause for inconsistencies.
The proposed solution is to use a new table to track the progress of block's data indexing.
By using a specific table, whose rows are deleted when there are no more pending operations on the relative block, we make joins quick and keep them to a minimum.
This is also meant to simplify all inserts and updates and only perform deletes when strictly necessary.