Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease loaders showing delay on the main page #2878

Merged
merged 2 commits into from
Nov 26, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Nov 26, 2019

Motivation

Loaders showing delay on the main page was set to 1 second #2324, what is too long. It was decreased to 100 ms. It means if the data will not be fetched from the server in 100 ms, mock loaders will be shown.

Checklist for your Pull Request (PR)

@vbaranov vbaranov added ready for review This PR is ready for reviews. UI labels Nov 26, 2019
@vbaranov vbaranov self-assigned this Nov 26, 2019
@coveralls
Copy link

coveralls commented Nov 26, 2019

Pull Request Test Coverage Report for Build d1907bb0-d559-4e3b-af6a-91d143fe4f06

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.1%) to 76.18%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
Totals Coverage Status
Change from base Build d297bed9-74f4-4fd1-8c38-77caeacadae6: 1.1%
Covered Lines: 5357
Relevant Lines: 7032

💛 - Coveralls

@vbaranov vbaranov merged commit 545b282 into master Nov 26, 2019
@vbaranov vbaranov deleted the decrease-loaders-showing-delay branch November 26, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews. UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants