Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend paths for css/js assets #2851

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Nov 12, 2019

Motivation

Paths for non-critical, stakes, awesomplete assets are relative and do not include a part of path like /eth/mainnet and thus are not cached on the front-end because of haproxy configuration to not cache files that are from the root path ./

Changelog

Fix paths for non-critical, stakes, awesomplete assets

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Nov 12, 2019
@vbaranov vbaranov force-pushed the vb-fix-paths-for-front-assets branch from 03df57e to c7ee6da Compare November 12, 2019 12:04
@vbaranov vbaranov force-pushed the vb-fix-paths-for-front-assets branch from c7ee6da to 1c8da51 Compare November 12, 2019 12:05
@coveralls
Copy link

coveralls commented Nov 12, 2019

Pull Request Test Coverage Report for Build 774b1e50-4237-46c0-a391-f145336f0b84

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 58 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.8%) to 75.656%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/transform/addresses.ex 1 75.0%
apps/indexer/lib/indexer/block/fetcher.ex 3 83.13%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/http.ex 7 64.0%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/web_socket/web_socket_client.ex 47 18.75%
Totals Coverage Status
Change from base Build edb464cc-8f27-47bb-976a-e7c21c530861: -0.8%
Covered Lines: 5249
Relevant Lines: 6938

💛 - Coveralls

@vbaranov vbaranov marked this pull request as ready for review November 12, 2019 12:10
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Nov 12, 2019
@vbaranov vbaranov changed the title Fix paths for front assets Extend paths for css/js assets Nov 13, 2019
@vbaranov vbaranov merged commit cce850a into master Nov 19, 2019
@vbaranov vbaranov deleted the vb-fix-paths-for-front-assets branch November 19, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants