Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix realtime fetcher small skips feature #2843

Merged
merged 4 commits into from
Nov 7, 2019
Merged

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Nov 7, 2019

If indexing is started from scratch, realtime fetcher
tries to index large ranges of blocks. For example, 5..1852044.
It produces errors like
failed to fetch: :emfile. Block will be retried by catchup indexer

This PR limits the number of blocks to 10

Changelog

  • fix realtime fetcher small skips feature

If indexing is started from scratch, realtime fetcher
tries to index large ranges of blocks. For example, 5..1852044.
It produces errors like
`failed to fetch: :emfile.  Block will be retried by catchup indexer`

This PR limits the number of blocks to 10
@coveralls
Copy link

coveralls commented Nov 7, 2019

Pull Request Test Coverage Report for Build 9f292f06-a3ba-48c1-be0e-1398eeea1271

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 76 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-1.09%) to 75.382%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/http/httpoison.ex 1 0.0%
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/case/parity/http_websocket.ex 1 0.0%
apps/indexer/lib/indexer/transform/addresses.ex 1 75.0%
apps/indexer/lib/indexer/block/fetcher.ex 3 83.13%
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/web_socket/case/parity.ex 4 0.0%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/http.ex 12 52.0%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/web_socket/web_socket_client.ex 53 11.25%
Totals Coverage Status
Change from base Build ad5ef839-68f3-4d4d-a043-1dd7f6b83867: -1.09%
Covered Lines: 5230
Relevant Lines: 6938

💛 - Coveralls

@vbaranov vbaranov merged commit 675b2b6 into master Nov 7, 2019
@vbaranov vbaranov deleted the ab-fix-small-skips-feature branch November 7, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants