Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate token transfers and transactions #2825

Merged
merged 22 commits into from
Nov 14, 2019
Merged

separate token transfers and transactions #2825

merged 22 commits into from
Nov 14, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Oct 31, 2019 •
edited
Loading

resolves #2824

Changelog

  • separate token transfers and transactions

@coveralls
Copy link

coveralls commented Nov 1, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 60c29d26-044a-4477-bdb9-e4151c917e93

  • 7 of 33 (21.21%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 76.393%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/address_view.ex 0 1 0.0%
apps/explorer/lib/explorer/chain/transaction.ex 3 5 60.0%
apps/block_scout_web/lib/block_scout_web/views/address_token_transfer_view.ex 0 4 0.0%
apps/block_scout_web/lib/block_scout_web/controllers/address_token_transfer_controller.ex 0 19 0.0%
Totals Coverage Status
Change from base Build c57e4232-06eb-4954-9024-7fbf8dd43587: -0.07%
Covered Lines: 5320
Relevant Lines: 6964
💛 - Coveralls

@ayrat555 ayrat555 mentioned this pull request Nov 1, 2019
Closed
@ayrat555 ayrat555 marked this pull request as ready for review November 5, 2019 11:49
vbaranov
vbaranov requested changes Nov 6, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555

  1. Sokol /address/0xd57be09da99d2b8fbed4e92fdfd04a956a770824/transactions
    Screenshot 2019-11-06 at 12 18 08

  2. Let's place Token transfers tab as a 2nd tab

  3. Filtering should be available on Token transfers tab too

@vbaranov vbaranov self-requested a review November 14, 2019 15:42
@vbaranov vbaranov merged commit 73e7e0b into master Nov 14, 2019
@vbaranov vbaranov deleted the ab-separate-token-transfers-and-transaction branch November 14, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@pasqu4le pasqu4le Awaiting requested review from pasqu4le

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate token transfers and other transactions on account page
3 participants
@ayrat555 @coveralls @vbaranov