Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "We are indexing this chain right now. Some of the counts may be inaccurate" banner if no txs in blockchain #2793

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Oct 21, 2019

Motivation

Blokcscout shows " n% Blocks Indexed - We're indexing this chain right now. Some of the counts may be inaccurate." banner at the top even if blockchain doesn't have transactions

Changelog

Enhancements

If there are no transactions in the blockchain, the banner is hidden

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-hide-banner-if-no-txs branch 2 times, most recently from 1af8c72 to 3103b3a Compare October 21, 2019 15:44
@coveralls
Copy link

coveralls commented Oct 21, 2019

Pull Request Test Coverage Report for Build af0147d1-d895-44fd-91d1-da759083307f

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 76.922%

Totals Coverage Status
Change from base Build ddd4c339-6780-406f-94a1-6f24040565a1: 0.2%
Covered Lines: 5293
Relevant Lines: 6881

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-hide-banner-if-no-txs branch 3 times, most recently from 579ebf6 to fdddb49 Compare October 21, 2019 16:18
@vbaranov vbaranov added the wip label Oct 21, 2019
@vbaranov vbaranov force-pushed the vb-hide-banner-if-no-txs branch 4 times, most recently from a36a0f8 to 6ce59ba Compare October 21, 2019 17:16
@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed wip labels Oct 22, 2019
@vbaranov vbaranov self-assigned this Oct 22, 2019
@vbaranov vbaranov merged commit 7a77d71 into master Oct 23, 2019
@vbaranov vbaranov deleted the vb-hide-banner-if-no-txs branch October 23, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants