optimize token token transfers query #2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the longes part of the query is ordering. Removing order clause from the query makes a query much faster. It's because by default indexes are ordered in ASC order
Pull Request Test Coverage Report for Build 640ae303-7405-468b-9b8f-a25e63b4fc58
💛 - Coveralls |
Pull Request Test Coverage Report for Build 26273762-4565-4783-b43f-317d7eea19c4
💛 - Coveralls |
pasqu4le
approved these changes
Oct 10, 2019
vbaranov
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
@ayrat555 approved since this PR partially fixes the issue for some tokens. However, there are examples of tokens' pages still exist, that do not load token transfers:
/tokens/0x6fb3e0a217407efff7ca062d46c26e5d60a14d69/token_transfers
/tokens/0x77fe30b2cf39245267c0a5084b66a560f1cf9e1f/token_transfers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
the longes part of the query is ordering.
Removing the order clause from the query makes a
query much faster. It's because by default indexes
are ordered in ASC order
part of #2644
Update: I added this migration on stg. CryptoKitties token transfers don't fail anymore. The longest part is counters now
tokens/0x06012c8cf97bead5deae237070f9587f8e7a266d/token_transfersChangelog