Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG network icons #2640

Merged
merged 2 commits into from
Aug 29, 2019
Merged

SVG network icons #2640

merged 2 commits into from
Aug 29, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Aug 28, 2019

Motivation

Icons are vague on Retina displays

Changelog

  • SVG images are added for networks selector
  • PNG images are removed
  • CSS is changed to use SVG images

BEFORE:

Screenshot 2019-08-28 at 12 32 43

AFTER:

Screenshot 2019-08-28 at 12 22 44

Checklist for your PR

@vbaranov vbaranov requested review from pasqu4le, saneery, ayrat555 and liberumed and removed request for pasqu4le August 28, 2019 09:33
@vbaranov vbaranov self-assigned this Aug 28, 2019
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Aug 28, 2019
@coveralls
Copy link

coveralls commented Aug 28, 2019

Pull Request Test Coverage Report for Build caa53a49-157b-4aa6-8d60-3d3b0ac23870

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.996%

Totals Coverage Status
Change from base Build e37df190-7246-494d-9d68-7b147df7add3: 0.0%
Covered Lines: 5194
Relevant Lines: 6575

💛 - Coveralls

@vbaranov vbaranov merged commit e8193be into master Aug 29, 2019
@vbaranov vbaranov deleted the vb-network-icons-svg branch August 29, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants