-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deduplicate coin history records by delta #2616
Conversation
On coin history page we show records that are found in the db. Since we may fetch a lot of duplicated balances for the same address if its balance is not changes for multiple blocks. This PR adds deduplication by delta value to remove duplication.
Pull Request Test Coverage Report for Build 603c30bf-58f2-45ee-8f37-c3fbd2696725
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deduplication significantly slowed down coin balance history page. Please check /address/0xc8dfcec53ab1102a38e8f96be8eba37fc5340c99/coin_balances
.
We show the changes in the 3 months range on the chart. Which conditions are provided in the query to get coin balance history? Could post a link to the query here? I suppose we should get data in a query in the same range if it is not so.
@vbaranov I compared page loading with and without deduplication. they seem it's the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it looks like it was a temporary issue. Times are comparatively equal.
On coin history page we show records that are found
in the db. Since we may fetch a lot of duplicated balances
for the same address if its balance is not changes for
multiple blocks.
This PR adds deduplication by delta value to remove duplication.
fixes #2565
Changelog