Correctly handle dynamically created Bootstrap tooltips #2551

goodsoft · 2019-08-12T12:43:24Z

Problem: there are a lot of tooltips in staking UI that are located in dynamically created DOM, which are currently not initialized correctly.

Solution: initialize tooltips on <body> with selector parameter.

Checklist for your PR

I added an entry to CHANGELOG.md with this PR
If I added new functionality, I added tests covering it.
If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
I checked whether I should update the docs and did so if necessary
If I added/changed/removed ENV var, I should update the list of env vars in https://github.com/poanetwork/blockscout/blob/master/docs/env-variables.md to reflect changes in the table here https://poanetwork.github.io/blockscout/#/env-variables?id=blockscout-env-variables. I've set master in the Version column.
If I add new indices into DB, I checked, that they don't redundant with PGHero or other tools

Problem: there are a lot of tooltips in staking UI that are located in dynamically created DOM, which are currently not initialized correctly. Solution: initialize tooltips on <body> with selector parameter.

goodsoft added 2 commits August 12, 2019 15:33

Correctly handle dynamically created Bootstrap tooltips

b7c89cd

Problem: there are a lot of tooltips in staking UI that are located in dynamically created DOM, which are currently not initialized correctly. Solution: initialize tooltips on <body> with selector parameter.

Update CHANGELOG.md

0e9982d

goodsoft requested review from vbaranov, pasqu4le and ayrat555 and removed request for vbaranov August 12, 2019 13:36

goodsoft added the ready for review This PR is ready for reviews. label Aug 12, 2019

ayrat555 approved these changes Aug 12, 2019

View reviewed changes

vbaranov approved these changes Aug 12, 2019

View reviewed changes

vbaranov merged commit 3c927af into master Aug 12, 2019

vbaranov deleted the gs-dynamic-tooltips branch August 12, 2019 14:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correctly handle dynamically created Bootstrap tooltips #2551

Correctly handle dynamically created Bootstrap tooltips #2551

goodsoft commented Aug 12, 2019 •

edited

Loading

Correctly handle dynamically created Bootstrap tooltips #2551

Correctly handle dynamically created Bootstrap tooltips #2551

Conversation

goodsoft commented Aug 12, 2019 • edited Loading

Checklist for your PR

goodsoft commented Aug 12, 2019 •

edited

Loading